linux-kernel - Re: [PATCH v1 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jan 2022 00:37:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xin Ji <xji@...logixsemi.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        bliang@...logixsemi.com, qwen@...logixsemi.com,
        jli@...logixsemi.com, Xin Ji <xji@...logixsemi.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v1 2/2] usb: typec: anx7411: Add Analogix PD ANX7411
 support

Hi Xin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on robh/for-next peter-chen-usb/for-usb-next v5.16 next-20220118]
[cannot apply to balbi-usb/testing/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xin-Ji/dt-bindings-usb-Add-analogix-anx7411-PD-binding/20220119-190352
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220120/202201200042.BIqTHWGV-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f7b7138a62648f4019c55e4671682af1f851f295)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/760b0d28447fcaef7a39a20ebce9a4fb96cc0c7d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xin-Ji/dt-bindings-usb-Add-analogix-anx7411-PD-binding/20220119-190352
        git checkout 760b0d28447fcaef7a39a20ebce9a4fb96cc0c7d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/usb/typec/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/typec/anx7411.c:835:6: warning: no previous prototype for function 'anx7411_port_unregister_altmodes' [-Wmissing-prototypes]
   void anx7411_port_unregister_altmodes(struct typec_altmode **adev)
        ^
   drivers/usb/typec/anx7411.c:835:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void anx7411_port_unregister_altmodes(struct typec_altmode **adev)
   ^
   static 
   1 warning generated.


vim +/anx7411_port_unregister_altmodes +835 drivers/usb/typec/anx7411.c

   834	
 > 835	void anx7411_port_unregister_altmodes(struct typec_altmode **adev)
   836	{
   837		int i;
   838	
   839		for (i = 0; i < MAX_ALTMODE; i++)
   840			if (adev[i]) {
   841				typec_unregister_altmode(adev[i]);
   842				adev[i] = NULL;
   843			}
   844	}
   845	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org