linux-kernel - Re: [PATCH v2] ASoC: codecs: Check for error pointer after calling devm_regmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YehAdeQAlPubkNZ3@sirena.org.uk>
Date:   Wed, 19 Jan 2022 16:46:45 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     cezary.rojewski@...el.com, srinivas.kandagatla@...aro.org,
        bgoswami@...eaurora.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: Check for error pointer after calling
 devm_regmap_init_mmio

On Fri, Jan 14, 2022 at 02:57:13PM +0800, Jiasheng Jiang wrote:
> Since the possible failure of the devm_regmap_init_mmio(), it will
> return error pointer and be assigned to the regmap.
> Then the error pointer will be dereferenced.
> For example rx->regmap will be used in rx_macro_mclk_enable().
> Therefore, it should be better to check it.

This doesn't apply against current code, please check and resend.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)