linux-kernel - Re: [PATCH] staging: fwserial: rearrange comment to avoid warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220119175739.GM1951@kadam>
Date:   Wed, 19 Jan 2022 20:57:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Ajith P V <ajithpv.linux@...il.com>, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fwserial: rearrange comment to avoid warning

On Wed, Jan 19, 2022 at 07:19:24AM -0800, Randy Dunlap wrote:
> Hi--
> 
> On 1/19/22 00:41, Ajith P V wrote:
> > fwserial.h comment contains word "bits" 2 times together.
> > The sentence required this however it produce warning.
> > Change the comment to make it proper.
> 
> Is that a warning from checkpatch?

Yeah.  You're right.

WARNING: Possible repeated word: 'bits'
#207: FILE: drivers/staging/fwserial/fwserial.h:207:
+ *         bits 15..0  correspond to TIOCM_* bits
                                              ^^^^
+ *         bits 19..16 reserved for mctrl
            ^^^^
> If so, it's OK to ignore something like that.
> checkpatch isn't perfect and we know that.

Yep.  Checkpatch is not the boss of us.

regards,
dan carpenter