[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YeirvbTh5Cztcgxh@ripper>
Date: Wed, 19 Jan 2022 16:24:29 -0800
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Alistair Delva <adelva@...gle.com>
Cc: linux-kernel@...r.kernel.org,
Rishabh Bhatnagar <rishabhb@...eaurora.org>,
stable@...r.kernel.org, Ohad Ben-Cohen <ohad@...ery.com>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Sibi Sankar <sibis@...eaurora.org>,
linux-remoteproc@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH] remoteproc: Fix count check in rproc_coredump_write()
On Wed 19 Jan 15:21 PST 2022, Alistair Delva wrote:
> Check count for 0, to avoid a potential underflow. Make the check the
> same as the one in rproc_recovery_write().
>
> Fixes: 3afdc59e4390 ("remoteproc: Add coredump debugfs entry")
> Signed-off-by: Alistair Delva <adelva@...gle.com>
> Cc: Rishabh Bhatnagar <rishabhb@...eaurora.org>
> Cc: stable@...r.kernel.org
> Cc: Ohad Ben-Cohen <ohad@...ery.com>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Cc: Sibi Sankar <sibis@...eaurora.org>
> Cc: linux-remoteproc@...r.kernel.org
> Cc: kernel-team@...roid.com
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
Regards,
Bjorn
> ---
> drivers/remoteproc/remoteproc_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
> index b5a1e3b697d9..581930483ef8 100644
> --- a/drivers/remoteproc/remoteproc_debugfs.c
> +++ b/drivers/remoteproc/remoteproc_debugfs.c
> @@ -76,7 +76,7 @@ static ssize_t rproc_coredump_write(struct file *filp,
> int ret, err = 0;
> char buf[20];
>
> - if (count > sizeof(buf))
> + if (count < 1 || count > sizeof(buf))
> return -EINVAL;
>
> ret = copy_from_user(buf, user_buf, count);
> --
> 2.30.2
>
Powered by blists - more mailing lists