linux-kernel - Re: [ASUS EC Sensors v7 1/3] hwmon: (asus-ec-sensors) add driver for ASUS EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jan 2022 16:45:40 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eugene Shalygin <eugene.shalygin@...il.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Denis Pauk <pauk.denis@...il.com>,
        Jean Delvare <jdelvare@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-hwmon@...r.kernel.org
Subject: Re: [ASUS EC Sensors v7 1/3] hwmon: (asus-ec-sensors) add driver for
 ASUS EC

On Wed, Jan 19, 2022 at 04:25:41AM +0100, Eugene Shalygin wrote:
> I did not read carefully what I committed and now two small
> corrections are required (see inline). Should I resend again?
> 

Wait for a couple of days in case there is test coverage
or other feedback.

Guenter

> On Tue, 18 Jan 2022 at 17:53, Eugene Shalygin <eugene.shalygin@...il.com> wrote:
> > +       DMI_EXACT_MATCH_BOARD(VENDOR_ASUS_UPPER_CASE, "ROG STRIX X570-F GAMING",
> > +               SENSOR_SET_TEMP_CHIPSET_CPU_MB |
> > +               SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CHIPSET
> Redundant line break.
> > +       ),
> > +       DMI_EXACT_MATCH_BOARD(VENDOR_ASUS_UPPER_CASE, "ROG STRIX X570-I GAMING",
> > +               SENSOR_TEMP_T_SENSOR | SENSOR_FAN_VRM_HS |
> > +               SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU),
> 
> 
> > +struct ec_sensors_data {
> > +       unsigned long board_sensors;
> > +       struct ec_sensor *sensors;
> > +       /** EC registers to read from */
> > +       u16 *registers;
> > +       u8 *read_buffer;
> > +       /** sorted list of unique register banks */
> > +       u8 banks[ASUS_EC_MAX_BANK + 1];
> > +       /** in jiffies */
> > +       unsigned long last_updated;
> > +       acpi_handle aml_mutex;
> > +       /** number of board EC sensors */
> > +       u8 nr_sensors;
> > +       /** number of EC registers to read (sensor might span more than 1 register) */
> > +       u8 nr_registers;
> > +       /** number of unique register banks */
> > +       u8 nr_banks;
> > +};
> 
> Forgot to remove doc-comments.
> 
> Thanks,
> Eugene