linux-kernel - RE: [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node into /soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB89460673836CDB9AEFC0C09A8F5A9@AS8PR04MB8946.eurprd04.prod.outlook.com>
Date:   Thu, 20 Jan 2022 08:06:48 +0000
From:   Leo Li <leoyang.li@....com>
To:     Michael Walle <michael@...le.cc>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: RE: [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node into /soc



> -----Original Message-----
> From: Michael Walle <michael@...le.cc>
> Sent: Tuesday, August 31, 2021 9:40 PM
> To: linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Shawn Guo <shawnguo@...nel.org>; Leo Li <leoyang.li@....com>; Rob
> Herring <robh+dt@...nel.org>; Vladimir Oltean <vladimir.oltean@....com>;
> Michael Walle <michael@...le.cc>
> Subject: [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node into /soc
> 
> Move it inside the /soc subnode because it is part of the CCSR space.

I just noticed that the dp0_out label has been changed to dpi0_out besides the move.  Is this an intentional change or a typo?  If intentional we probably should mention it, otherwise we should change it back as it is breaking build for off-tree patch that uses the label.

> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 41 ++++++++++---------
>  1 file changed, 21 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 9a65a7118faa..92e4f004c1c2 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -793,6 +793,27 @@ QORIQ_CLK_PLL_DIV(16)>,
>  			clock-names = "wdog_clk", "apb_pclk";
>  		};
> 
> +		malidp0: display@...0000 {
> +			compatible = "arm,mali-dp500";
> +			reg = <0x0 0xf080000 0x0 0x10000>;
> +			interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> +				     <0 223 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "DE", "SE";
> +			clocks = <&dpclk>,
> +				 <&clockgen QORIQ_CLK_HWACCEL 2>,
> +				 <&clockgen QORIQ_CLK_HWACCEL 2>,
> +				 <&clockgen QORIQ_CLK_HWACCEL 2>;
> +			clock-names = "pxlclk", "mclk", "aclk", "pclk";
> +			arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> +			arm,malidp-arqos-value = <0xd000d000>;
> +
> +			port {
> +				dpi0_out: endpoint {
> +
> +				};
> +			};
> +		};
> +
>  		sai1: audio-controller@...0000 {
>  			#sound-dai-cells = <0>;
>  			compatible = "fsl,vf610-sai";
> @@ -1139,24 +1160,4 @@ ftm_alarm0: timer@...0000 {
>  		};
>  	};
> 
> -	malidp0: display@...0000 {
> -		compatible = "arm,mali-dp500";
> -		reg = <0x0 0xf080000 0x0 0x10000>;
> -		interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> -			     <0 223 IRQ_TYPE_LEVEL_HIGH>;
> -		interrupt-names = "DE", "SE";
> -		clocks = <&dpclk>,
> -			 <&clockgen QORIQ_CLK_HWACCEL 2>,
> -			 <&clockgen QORIQ_CLK_HWACCEL 2>,
> -			 <&clockgen QORIQ_CLK_HWACCEL 2>;
> -		clock-names = "pxlclk", "mclk", "aclk", "pclk";
> -		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> -		arm,malidp-arqos-value = <0xd000d000>;
> -
> -		port {
> -			dp0_out: endpoint {
> -
> -			};
> -		};
> -	};
>  };
> --
> 2.30.2