linux-kernel - Re: [PATCH] devtmpfs: drop redundant fs parameters from internal fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220120084612.hl5ekd4aplmduj6u@wittgenstein>
Date:   Thu, 20 Jan 2022 09:46:12 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Anthony Iliopoulos <ailiop@...e.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Howells <dhowells@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] devtmpfs: drop redundant fs parameters from internal fs

On Wed, Jan 19, 2022 at 11:02:48PM +0100, Anthony Iliopoulos wrote:
> The internal_fs_type is mounted via vfs_kernel_mount() and is never
> registered as a filesystem, thus specifying the parameters is redundant
> as those params will not be validated by fs_validate_description().
> 
> Both {shmem,ramfs}_fs_parameters are anyway validated when those
> respective filesystems are first registered, so there is no reason to
> pass them to devtmpfs too, drop them.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@...e.com>
> ---

Ah yes, I "complained" about this on the patch re-enabling
reconfigure_mnt() for devtmpfs.

Acked-by: Christian Brauner <christian.brauner@...ntu.com>