[<prev] [next>] [day] [month] [year] [list]
Message-ID: <b846de5f-cf30-c000-ea37-61d79bcd4e7e@baylibre.com>
Date: Thu, 20 Jan 2022 09:59:03 +0100
From: Neil Armstrong <narmstrong@...libre.com>
To: "shunzhou.jiang@...ogic.com" <shunzhou.jiang@...ogic.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc: devicetree <devicetree@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-amlogic <linux-amlogic@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
khilman <khilman@...libre.com>, jbrunet <jbrunet@...libre.com>
Subject: Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller
Hi Shunzhou,
On 18/01/2022 03:26, shunzhou.jiang@...ogic.com wrote:
> Dears Neil & Martin:
> Sorry for my late reply
> S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash
> S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb
> S4_ETH: for ethernet online wakeup, and if power down, status also not right
>>> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON),
>>> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON),
>>> + SEC_PD(S4_GE2D, 0),
>>> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON),
Thanks for clarifications, can you resend the patchset with those infos in comments like it was done for A1 ?
Thanks,
Neil
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Shunzhou Jiang
> SW Department
>
>
> *From:* Neil Armstrong <mailto:narmstrong@...libre.com>
> *Date:* 2022-01-12 16:36
> *To:* Martin Blumenstingl <mailto:martin.blumenstingl@...glemail.com>; Shunzhou.Jiang <mailto:shunzhou.jiang@...ogic.com>
> *CC:* devicetree <mailto:devicetree@...r.kernel.org>; linux-arm-kernel <mailto:linux-arm-kernel@...ts.infradead.org>; linux-amlogic <mailto:linux-amlogic@...ts.infradead.org>; linux-kernel <mailto:linux-kernel@...r.kernel.org>; khilman <mailto:khilman@...libre.com>; jbrunet <mailto:jbrunet@...libre.com>
> *Subject:* Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller
> [ EXTERNAL EMAIL ]
>
> Hi Shunzhou,
>
> On 30/12/2021 23:15, Martin Blumenstingl wrote:
> > On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang
> > <shunzhou.jiang@...ogic.com> wrote:
> >>
> >> From: Shunzhou Jiang <shunzhou.jiang@...ogic.com>
> >>
> >> Add support s4 Power controller. In s4, power control
> >> registers are in secure domain, and should be accessed by smc.
> >>
> >> Signed-off-by: Shunzhou Jiang <shunzhou.jiang@...ogic.com>
> > Also here I don't have any datasheet to compare this with, so this gets my:
> > Acked-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> >
> > [...]
> >> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON),
> >> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON),
> >> + SEC_PD(S4_GE2D, 0),
> >> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON),
> > For the A1 SoC's UART entry we have the following comment which
> > explains why we want to to be "always on":
> > UART should keep working in ATF after suspend and before resume
> >
> > If for some reason you need to re-send this series then it would be
> > great if you could add a comment above each entry with
> > GENPD_FLAG_ALWAYS_ON.
> > It will help others (like me) understand these SoCs better.
>
> Can you resend with those comments added so I can apply the patches ?
>
> Thanks,
> Neil
>
> >
> >
> > Best regards,
> > Martin
> >
>
>
Powered by blists - more mailing lists