linux-kernel - RE: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a354d7c1dce4463ea57706dd5443fe7a@sphcmbx02.sunplus.com.tw>
Date:   Thu, 20 Jan 2022 09:23:06 +0000
From:   Lh Kuo 郭力豪 <lh.Kuo@...plus.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Li-hao Kuo <lhjeff911@...il.com>
CC:     Philipp Zabel <p.zabel@...gutronix.de>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: RE: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021

Hi Andy Shevchenko :

Thanks for your comment, I have some questions as below.

> > +       if (xfer->tx_buf)
> > +               dma_unmap_single(dev, xfer->tx_dma, xfer->len, DMA_TO_DEVICE);
> > +       if (xfer->rx_buf)
> > +               dma_unmap_single(dev, xfer->rx_dma, xfer->len,
> > + DMA_FROM_DEVICE);
> 
> Why can't you use SPI core DMA mapping code?

I didn't find the SPI core DMA mapping code for single maping. 
The method currently used is the general DMA single-map code usage method.


> 
> > +       device_set_node(&ctlr->dev, pdev->dev.fwnode);
> 
> Use dev_fwnode() in the second argument.
>

You mean as below ?

device_set_node(&ctlr->dev, dev_fwnode(dev));

Best Regards,
Li-hao Kuo