linux-kernel - Re: [PATCH v2] media: dt-bindings: media: renesas,csi2: Update data-lanes property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jan 2022 11:40:29 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc:     Niklas Söderlund <niklas.soderlund@...natech.se>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Prabhakar <prabhakar.csengg@...il.com>,
        Biju Das <biju.das.jz@...renesas.com>
Subject: Re: [PATCH v2] media: dt-bindings: media: renesas,csi2: Update
 data-lanes property

Hello Prabhakar

On Thu, Jan 20, 2022 at 01:25:53AM +0000, Lad Prabhakar wrote:
> CSI-2 (CSI4LNK0) on R-Car and RZ/G2 supports 4-lane mode which is already
> handled by rcar-csi2.c driver. This patch updates the data-lanes property
> to describe the same.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
> Hi All,
>
> Instead of adding uniqueItems:true into SoC binding doc's I think we could
> add this in video-interfaces.yaml for data-lanes property. Any thoughts on this?
>

As repeating items are not allowed I think it's a good idea.
In the meantime this patch looks good to me

Reviewed-by: Jacopo Mondi <jacopo+renesas@...ndi.org>

Thanks
  j

> Cheers,
> Prabhakar
>
> v1->v2
> * Dropped const items
> * Added uniqueItems
>
> v1:
> https://lore.kernel.org/lkml/20220118163413.ge2b4g75yhfqvq3x@uno.localdomain/T/
> ---
>  Documentation/devicetree/bindings/media/renesas,csi2.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> index e6a036721082..a5a1b570025a 100644
> --- a/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> @@ -67,7 +67,11 @@ properties:
>                  maxItems: 1
>
>                data-lanes:
> -                maxItems: 1
> +                minItems: 1
> +                maxItems: 4
> +                uniqueItems: true
> +                items:
> +                  maximum: 4
>
>              required:
>                - clock-lanes
> --
> 2.17.1
>