linux-kernel - [PATCH 0/2] fix crash by reading /proc/diskstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220120105248.117025-1-dwagner@suse.de>
Date:   Thu, 20 Jan 2022 11:52:46 +0100
From:   Daniel Wagner <dwagner@...e.de>
To:     linux-block@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Hannes Reinecke <hare@...e.de>, Daniel Wagner <dwagner@...e.de>
Subject: [PATCH 0/2] fix crash by reading /proc/diskstats

During failover nvme-tcp tests in a HA setup a crash orccured. iostat
was running in the background while the test was executed.

I am not sure if the fix is correct. I am unsure if using
blk_queue_enter() is the right thing. But when starring at the code
snipped I saw in older version blk_queue_enter() was used but got
evenutally replaced by the rcu_read_lock() as far I understand at the
moment... So any tip here would be highly appreciated.

Daniel

Daniel Wagner (2):
  block: remove commented out code from diskstats_show
  block: hold queue lock while iterating in diskstats_show

 block/genhd.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

-- 
2.29.2