linux-kernel - Re: [PATCH 1/2] block: remove commented out code from diskstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jan 2022 12:02:49 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     Daniel Wagner <dwagner@...e.de>, linux-block@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 1/2] block: remove commented out code from diskstats_show

On 1/20/22 11:52 AM, Daniel Wagner wrote:
> The diskstats format is ABI, so we just can't add a new header. The
> code snippet has been commented out since at least v2.6.12-rc2.
> Remove it.
> 
> Signed-off-by: Daniel Wagner <dwagner@...e.de>
> ---
>  block/genhd.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/block/genhd.c b/block/genhd.c
> index 626c8406f21a..c9d4386dd177 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1162,14 +1162,6 @@ static int diskstats_show(struct seq_file *seqf, void *v)
>  	struct disk_stats stat;
>  	unsigned long idx;
>  
> -	/*
> -	if (&disk_to_dev(gp)->kobj.entry == block_class.devices.next)
> -		seq_puts(seqf,	"major minor name"
> -				"     rio rmerge rsect ruse wio wmerge "
> -				"wsect wuse running use aveq"
> -				"\n\n");
> -	*/
> -
>  	rcu_read_lock();
>  	xa_for_each(&gp->part_tbl, idx, hd) {
>  		if (bdev_is_partition(hd) && !bdev_nr_sectors(hd))
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer