linux-kernel - Re: [PATCH v3 2/4] Watchdog: sp5100_tco: Refactor MMIO base address initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf6_SKT94rDQMLWah-WgdP=w1YZ=X+cHS0SWr_26b+u0g@mail.gmail.com>
Date:   Thu, 20 Jan 2022 13:07:52 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Terry Bowman <Terry.Bowman@....com>
Cc:     Guenter Roeck <linux@...ck-us.net>, linux-watchdog@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Wolfram Sang <wsa@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Robert Richter <rrichter@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Mario Limonciello <Mario.Limonciello@....com>
Subject: Re: [PATCH v3 2/4] Watchdog: sp5100_tco: Refactor MMIO base address initialization

On Wed, Jan 19, 2022 at 6:57 PM Terry Bowman <Terry.Bowman@....com> wrote:
> On 1/19/22 5:53 AM, Andy Shevchenko wrote:
> > On Tue, Jan 18, 2022 at 10:23 PM Terry Bowman <terry.bowman@....com> wrote:

> Ok. I'll reduce the patches' to/cc list to only contain maintainers owning
> the current patch. I prefer to leave the lengthy list in the cover letter
> if that is ok because it will not be added to the tree but will provide
> context this series has multiple systems and may need communication
> between maintainers. I'll use the -to & -cc commandline as you mentioned to
> send to the longer list of recipients without cluttering the patch. Let me
> know if you prefer otherwise.

My point is that: supply the list implicitly.
For the help of choosing the right people I have written a script [1]
that shows a very good heuristics approach to me.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

...

> >> +       if (!devm_request_mem_region(dev, mmio_addr,
> >> +                                   SP5100_WDT_MEM_MAP_SIZE,
> >> +                                   dev_name)) {
> >> +               dev_dbg(dev, "MMIO address 0x%08x already in use\n",
> >> +                       mmio_addr);
> >> +               return -EBUSY;
> >> +       }
> >> +
> >> +       tco->tcobase = devm_ioremap(dev, mmio_addr,
> >> +                                   SP5100_WDT_MEM_MAP_SIZE);
> >> +       if (!tco->tcobase) {
> >> +               dev_dbg(dev, "MMIO address 0x%08x failed mapping.\n",
> >> +                       mmio_addr);

> > On top of above it's a NIH devm_ioremap_resource().
>
> I'm not familiar with NIH term. My friends google and grep weren't much help.

[2]: https://en.wikipedia.org/wiki/Not_invented_here

Means that you could very well simplify the code by using existing functions.

...

> > Okay, I see this is the original code like this... Perhaps it makes
> > sense to reshuffle them (indentation-wise) at the same time and
> > mention this in the changelog.

Here is the explanation that I noticed that the code you move is
original, and not written by you.

-- 
With Best Regards,
Andy Shevchenko