[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YeljTuECoPfKn6VW@casper.infradead.org>
Date: Thu, 20 Jan 2022 13:27:42 +0000
From: Matthew Wilcox <willy@...radead.org>
To: alexs@...nel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...hat.com>,
Naoya Horiguchi <naoya.horiguchi@....com>,
Yu Zhao <yuzhao@...gle.com>, Arnd Bergmann <arnd@...db.de>,
Vlastimil Babka <vbabka@...e.cz>,
Mel Gorman <mgorman@...hsingularity.net>,
Johannes Weiner <hannes@...xchg.org>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/5] mm: remove page_is_file_lru function
On Thu, Jan 20, 2022 at 09:10:20PM +0800, alexs@...nel.org wrote:
> From: Alex Shi <alexs@...nel.org>
>
> This function could be full replaced by folio_is_file_lru, so no reason
> to keep a duplicate function.
This is not a helpful way to do this kind of replacement.
Instead of choosing a function to remove and doing a blind replacement,
choose a call site and convert the whole calling function to use folios.
Once you've removed all callers, you can remove the wrapper function.
Also, a number of changes here will conflict with patches I've already
posted. Try doing change_pte_range() in mprotect.c to get a feel for
how to convert a function entirely to folios.
Powered by blists - more mailing lists