linux-kernel - Re: [PATCH v4 3/3] mmc: mediatek: add support for SDIO eint IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YelqDifksEmtMv44@smile.fi.intel.com>
Date:   Thu, 20 Jan 2022 15:56:30 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Axe Yang <axe.yang@...iatek.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Satya Tangirala <satyat@...gle.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Lucas Stach <dev@...xeye.de>,
        Eric Biggers <ebiggers@...gle.com>,
        Andrew Jeffery <andrew@...id.au>,
        Stephen Boyd <swboyd@...omium.org>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        Yue Hu <huyue2@...ong.com>, Tian Tao <tiantao6@...ilicon.com>,
        angelogioacchino.delregno@...labora.com, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Yong Mao <yong.mao@...iatek.com>
Subject: Re: [PATCH v4 3/3] mmc: mediatek: add support for SDIO eint IRQ

On Thu, Jan 20, 2022 at 01:34:08PM +0800, Axe Yang wrote:
> On Wed, 2022-01-19 at 21:47 +0200, Andy Shevchenko wrote:
> > On Wed, Jan 19, 2022 at 06:32:12PM +0800, Axe Yang wrote:

...

> > > Signed-off-by: Axe Yang <axe.yang@...iatek.com>
> > 
> > The submitters SoB must be last among all SoB tags. Please, read
> > Submitting
> > Patches document carefully.
> > 
> > > Signed-off-by: Yong Mao <yong.mao@...iatek.com>
> > 
> > Who is they, why their SoB appeared here?
> 
> Yong Mao is the co-developer of this patch, I will reorder the SoB
> chains.

And you will need to add a corresponding tag.

...

> > > - * Copyright (c) 2014-2015 MediaTek Inc.
> > > + * Copyright (c) 2022 MediaTek Inc.
> > 
> > This doesn't feel right. Why did you remove old years?
> 
> I should keep the publish year 2014 of this driver.
> But I still think range 2014-2022 is the most appropriate way to change
> the copyright time. Over these years, mediatek is keeping maintaining
> this driver continuously. What do you think?

I guess I already showed my opinion on the topic? The common sense tells
me that it should be as simple as '2014-2015,2022' there.

-- 
With Best Regards,
Andy Shevchenko