linux-kernel - Re: [PATCH] fs: nilfs2: fix memory leak in nilfs_sysfs_create_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jan 2022 17:07:35 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Dongliang Mu <dzm91@...t.edu.cn>,
        Ryusuke Konishi <konishi.ryusuke@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: nilfs2: fix memory leak in
 nilfs_sysfs_create_device_group

Hi Dongliang,

On 1/20/22 16:44, Dongliang Mu wrote:
> The preivous commit 8fd0c1b0647a ("nilfs2: fix memory leak in
> nilfs_sysfs_delete_device_group") only handles the memory leak in the
> nilfs_sysfs_delete_device_group. However, the similar memory leak still
> occurs in the nilfs_sysfs_create_device_group.
> 
> Fix it by adding kobject_del when
> kobject_init_and_add succeeds, but one of the following calls fails.
> 
> Fixes: 8fd0c1b0647a ("nilfs2: fix memory leak in nilfs_sysfs_delete_device_group")

Why Fixes tag points to my commit? This issue was introduced before my patch

> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---
>   fs/nilfs2/sysfs.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
> index 379d22e28ed6..0b2db2b499d5 100644
> --- a/fs/nilfs2/sysfs.c
> +++ b/fs/nilfs2/sysfs.c
> @@ -995,7 +995,7 @@ int nilfs_sysfs_create_device_group(struct super_block *sb)
>   
>   	err = nilfs_sysfs_create_mounted_snapshots_group(nilfs);
>   	if (err)
> -		goto cleanup_dev_kobject;
> +		goto delete_dev_kobject;
>   
>   	err = nilfs_sysfs_create_checkpoints_group(nilfs);
>   	if (err)
> @@ -1027,6 +1027,9 @@ int nilfs_sysfs_create_device_group(struct super_block *sb)
>   delete_mounted_snapshots_group:
>   	nilfs_sysfs_delete_mounted_snapshots_group(nilfs);
>   
> +delete_dev_kobject:
> +	kobject_del(&nilfs->ns_dev_kobj);
> +
>   cleanup_dev_kobject:
>   	kobject_put(&nilfs->ns_dev_kobj);
>   	kfree(nilfs->ns_dev_subgroups);
With regards,
Pavel Skripkin