| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Jan 2022 11:27:44 +0800
From: kernel test robot <lkp@...el.com>
To: Amit Cohen <amcohen@...dia.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org, Ido Schimmel <idosch@...dia.com>
Subject: [jpirko-mlxsw:ubridge 63/78]
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2652:6: warning:
variable 'vid' is used uninitialized whenever 'if' condition is true
tree: https://github.com/jpirko/linux_mlxsw ubridge
head: 976afb368c2f7efc2dc2436013895cc96ab06774
commit: 126a17e336358fd81470d0a19b64130234eca122 [63/78] mlxsw: Configure egress VID for unicast FDB entries
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220120/202201200839.oo2R9DV2-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f7b7138a62648f4019c55e4671682af1f851f295)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/126a17e336358fd81470d0a19b64130234eca122
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw ubridge
git checkout 126a17e336358fd81470d0a19b64130234eca122
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlxsw/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2652:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!bridge_port) {
^~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2652:2: note: remove the 'if' if its condition is always false
if (!bridge_port) {
^~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2646:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!mlxsw_sp_port_vlan) {
^~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2646:2: note: remove the 'if' if its condition is always false
if (!mlxsw_sp_port_vlan) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2642:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (mlxsw_sp_fid_is_dummy(mlxsw_sp, fid))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2642:2: note: remove the 'if' if its condition is always false
if (mlxsw_sp_fid_is_dummy(mlxsw_sp, fid))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2637:6: warning: variable 'vid' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!mlxsw_sp_port) {
^~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2661:64: note: uninitialized use occurs here
err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
^~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2637:2: note: remove the 'if' if its condition is always false
if (!mlxsw_sp_port) {
^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2628:9: note: initialize the variable 'vid' to silence this warning
u16 vid, fid;
^
= 0
4 warnings generated.
vim +2652 drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
8a1ab5d766396aa Jiri Pirko 2015-12-03 2616
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2617 static void mlxsw_sp_fdb_notify_mac_process(struct mlxsw_sp *mlxsw_sp,
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2618 char *sfn_pl, int rec_index,
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2619 bool adding)
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2620 {
c57529e1d5d882f Ido Schimmel 2017-05-26 2621 struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan;
c57529e1d5d882f Ido Schimmel 2017-05-26 2622 struct mlxsw_sp_bridge_device *bridge_device;
c57529e1d5d882f Ido Schimmel 2017-05-26 2623 struct mlxsw_sp_bridge_port *bridge_port;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2624 struct mlxsw_sp_port *mlxsw_sp_port;
1b40dc3d86724c7 Arkadi Sharshevsky 2017-06-08 2625 enum switchdev_notifier_type type;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2626 char mac[ETH_ALEN];
c934757d90000a9 Amit Cohen 2021-12-01 2627 u16 local_port;
9de6a80e061238d Ido Schimmel 2015-12-15 2628 u16 vid, fid;
12f1501e7511958 Jiri Pirko 2016-01-07 2629 bool do_notification = true;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2630 int err;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2631
9de6a80e061238d Ido Schimmel 2015-12-15 2632 mlxsw_reg_sfn_mac_unpack(sfn_pl, rec_index, mac, &fid, &local_port);
837ec05cfea0828 Danielle Ratson 2021-05-17 2633
c49bf28ae363005 Amit Cohen 2022-01-17 2634 if (WARN_ON_ONCE(!mlxsw_sp_local_port_is_valid(mlxsw_sp, local_port)))
837ec05cfea0828 Danielle Ratson 2021-05-17 2635 return;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2636 mlxsw_sp_port = mlxsw_sp->ports[local_port];
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2637 if (!mlxsw_sp_port) {
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2638 dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Incorrect local port in FDB notification\n");
12f1501e7511958 Jiri Pirko 2016-01-07 2639 goto just_remove;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2640 }
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2641
577fa14d210073b Ido Schimmel 2019-07-17 2642 if (mlxsw_sp_fid_is_dummy(mlxsw_sp, fid))
577fa14d210073b Ido Schimmel 2019-07-17 2643 goto just_remove;
577fa14d210073b Ido Schimmel 2019-07-17 2644
c57529e1d5d882f Ido Schimmel 2017-05-26 2645 mlxsw_sp_port_vlan = mlxsw_sp_port_vlan_find_by_fid(mlxsw_sp_port, fid);
c57529e1d5d882f Ido Schimmel 2017-05-26 2646 if (!mlxsw_sp_port_vlan) {
c57529e1d5d882f Ido Schimmel 2017-05-26 2647 netdev_err(mlxsw_sp_port->dev, "Failed to find a matching {Port, VID} following FDB notification\n");
12f1501e7511958 Jiri Pirko 2016-01-07 2648 goto just_remove;
aac78a44088728f Ido Schimmel 2015-12-15 2649 }
c57529e1d5d882f Ido Schimmel 2017-05-26 2650
c57529e1d5d882f Ido Schimmel 2017-05-26 2651 bridge_port = mlxsw_sp_port_vlan->bridge_port;
c57529e1d5d882f Ido Schimmel 2017-05-26 @2652 if (!bridge_port) {
c57529e1d5d882f Ido Schimmel 2017-05-26 2653 netdev_err(mlxsw_sp_port->dev, "{Port, VID} not associated with a bridge\n");
c57529e1d5d882f Ido Schimmel 2017-05-26 2654 goto just_remove;
aac78a44088728f Ido Schimmel 2015-12-15 2655 }
aac78a44088728f Ido Schimmel 2015-12-15 2656
c57529e1d5d882f Ido Schimmel 2017-05-26 2657 bridge_device = bridge_port->bridge_device;
c57529e1d5d882f Ido Schimmel 2017-05-26 2658 vid = bridge_device->vlan_enabled ? mlxsw_sp_port_vlan->vid : 0;
c57529e1d5d882f Ido Schimmel 2017-05-26 2659
12f1501e7511958 Jiri Pirko 2016-01-07 2660 do_fdb_op:
126a17e336358fd Amit Cohen 2022-01-04 2661 err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid, vid,
12f1501e7511958 Jiri Pirko 2016-01-07 2662 adding, true);
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2663 if (err) {
c0e01eac7ada785 Ido Schimmel 2017-05-18 2664 dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to set FDB entry\n");
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2665 return;
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2666 }
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2667
12f1501e7511958 Jiri Pirko 2016-01-07 2668 if (!do_notification)
12f1501e7511958 Jiri Pirko 2016-01-07 2669 return;
1b40dc3d86724c7 Arkadi Sharshevsky 2017-06-08 2670 type = adding ? SWITCHDEV_FDB_ADD_TO_BRIDGE : SWITCHDEV_FDB_DEL_TO_BRIDGE;
e9ba0fbc7dd23a7 Ido Schimmel 2018-10-17 2671 mlxsw_sp_fdb_call_notifiers(type, mac, vid, bridge_port->dev, adding);
a989cdb473c2fd9 Arkadi Sharshevsky 2017-06-08 2672
12f1501e7511958 Jiri Pirko 2016-01-07 2673 return;
12f1501e7511958 Jiri Pirko 2016-01-07 2674
12f1501e7511958 Jiri Pirko 2016-01-07 2675 just_remove:
12f1501e7511958 Jiri Pirko 2016-01-07 2676 adding = false;
12f1501e7511958 Jiri Pirko 2016-01-07 2677 do_notification = false;
12f1501e7511958 Jiri Pirko 2016-01-07 2678 goto do_fdb_op;
8a1ab5d766396aa Jiri Pirko 2015-12-03 2679 }
56ade8fe3fe1e13 Jiri Pirko 2015-10-16 2680
:::::: The code at line 2652 was first introduced by commit
:::::: c57529e1d5d882fbd6383163e2cb2e4ba3118174 mlxsw: spectrum: Replace vPorts with Port-VLAN
:::::: TO: Ido Schimmel <idosch@...lanox.com>
:::::: CC: David S. Miller <davem@...emloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists