linux-kernel - Re: [PATCH] net: mscc: ocelot: fix using match before it is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220120170852.d2iwgagxcu2eajj2@skbuf>
Date:   Thu, 20 Jan 2022 17:08:53 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     "trix@...hat.com" <trix@...hat.com>
CC:     Claudiu Manoil <claudiu.manoil@....com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "nathan@...nel.org" <nathan@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>
Subject: Re: [PATCH] net: mscc: ocelot: fix using match before it is set

On Tue, Jan 18, 2022 at 05:41:10AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Clang static analysis reports this issue
> ocelot_flower.c:563:8: warning: 1st function call argument
>   is an uninitialized value
>     !is_zero_ether_addr(match.mask->dst)) {
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The variable match is used before it is set.  So move the
> block.
> 
> Fixes: 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>

(sorry for the delay)