linux-kernel - [GIT PULL] xfs: legacy Irix ioctl housecleaning for 5.17-rc1, part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220120185920.GP13540@magnolia>
Date:   Thu, 20 Jan 2022 10:59:20 -0800
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org,
        david@...morbit.com, linux-kernel@...r.kernel.org,
        sandeen@...deen.net, hch@....de
Subject: [GIT PULL] xfs: legacy Irix ioctl housecleaning for 5.17-rc1, part 2

Hi Linus,

This is the third and final of a series of small pull requests that
perform some long overdue housecleaning of XFS ioctls.  This time, we're
withdrawing all variants of the ALLOCSP and FREESP ioctls from XFS'
userspace API.  This might be a little premature since we've only just
removed the functionality, but as I pointed out in the last pull
request, nobody (including fstests) noticed that it was broken for 20
years.

In response to the patch, we received a single comment from someone who
stated that they 'augment' the ioctl for their own purposes, but
otherwise acquiesced to the withdrawal.  I still want to try to clobber
these old ioctl definitions in 5.17, but if you decide that we should
wait longer, I can work with that.

As usual, I did a test-merge with upstream master as of a few minutes
ago, and didn't see any conflicts.  Please let me know if you encounter
any problems.

--D

The following changes since commit 4d1b97f9ce7c0d2af2bb85b12d48e6902172a28e:

  xfs: kill the XFS_IOC_{ALLOC,FREE}SP* ioctls (2022-01-17 09:16:41 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.17-merge-6

for you to fetch changes up to b3bb9413e717b44e4aea833d07f14e90fb91cf97:

  xfs: remove the XFS_IOC_{ALLOC,FREE}SP* definitions (2022-01-17 09:17:11 -0800)

----------------------------------------------------------------
Withdraw the XFS_IOC_ALLOCSP* and XFS_IOC_FREESP* ioctl definitions.

Remove the header definitions for these ioctls.  The just-removed
implementation has allowed callers to read stale disk contents for more
than **21 years** and nobody noticed or complained, which implies a lack
of users aside from exploit programs.

----------------------------------------------------------------
Darrick J. Wong (1):
      xfs: remove the XFS_IOC_{ALLOC,FREE}SP* definitions

 fs/xfs/libxfs/xfs_fs.h | 8 ++++----
 fs/xfs/xfs_ioctl.c     | 9 +++++++++
 fs/xfs/xfs_ioctl32.h   | 4 ----
 3 files changed, 13 insertions(+), 8 deletions(-)