linux-kernel - Re: [PATCH v3 1/3] dt-bindings: pwm: Fix node name pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yem0wtltC/6FklZu@robh.at.kernel.org>
Date:   Thu, 20 Jan 2022 13:15:14 -0600
From:   Rob Herring <robh@...nel.org>
To:     Nikita Travkin <nikita@...n.ru>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org,
        u.kleine-koenig@...gutronix.de, sboyd@...nel.org, krzk@...nel.org,
        linus.walleij@...aro.org, masneyb@...tation.org,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v3 1/3] dt-bindings: pwm: Fix node name pattern

On Thu, Jan 20, 2022 at 09:14:40PM +0500, Nikita Travkin wrote:
> It looks like it was intended to allow two types of node names with the
> binding:
> 
>  - With unit address, e.g. pwm@...00000

Yes, but the format of the unit-address is up to the parent bus which is 
outside the scope of this binding.

>  - With a suffix, e.g. pwm-clk

No. pwm-0, pwm-1, etc. only to cover the few cases with no unit-address. 

Third is just 'pwm' as the '*' on the end means 0 or more. Though a '?' 
would have been more correct.

> 
> However the pattern regex only correctly matches the first variant,
> as well as some incorrect ones.
> 
> Fix the regex to match only two patterns shown above. (Either unit
> address starting with @ and following with one or more hexademical
> digit or arbitrary suffix stating with - and at least one symbol long)
> 
> Fixes: 89650a1e3b6f ("dt-bindings: pwm: Convert PWM bindings to json-schema")
> Signed-off-by: Nikita Travkin <nikita@...n.ru>
> ---
>  Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
> index 3c01f85029e5..4926fe65886f 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
> @@ -13,7 +13,7 @@ select: false
>  
>  properties:
>    $nodename:
> -    pattern: "^pwm(@.*|-[0-9a-f])*$"
> +    pattern: "^pwm(@[0-9a-f]+|-.+)?$"
>  
>    "#pwm-cells":
>      description:
> -- 
> 2.30.2
> 
>