linux-kernel - Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25d1a334-5746-a53e-dbc0-f384333d14e1@nvidia.com>
Date:   Fri, 21 Jan 2022 11:22:56 +0530
From:   Ashish Mhetre <amhetre@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>, <linux-tegra@...r.kernel.org>,
        <krzysztof.kozlowski@...onical.com>, <linux-kernel@...r.kernel.org>
CC:     <Snikam@...dia.com>, <vdumpa@...dia.com>
Subject: Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward



On 1/20/2022 6:36 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> 20.01.2022 12:02, Ashish Mhetre пишет:
>> +             default:
>> +                     status_reg = MC_ERR_STATUS;
>> +                     addr_reg = MC_ERR_ADR;
>> +#if defined(CONFIG_ARCH_TEGRA_194_SOC) || \
>> +    defined(CONFIG_ARCH_TEGRA_234_SOC)
>> +                     addr_hi_reg = MC_ERR_ADR_HI;
>> +#endif
> 
> I'd add new "has_addr_hi_reg" field to struct tegra_mc_soc and use it
> instead of the ifdefs.
> 
> if (mc->soc->has_addr_hi_reg)
>          addr_hi_reg = MC_ERR_ADR_HI;
That's a good idea. I'll implement it in that way in next version.