lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Jan 2022 12:41:30 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Moses Christopher Bollavarapu <mosescb.dev@...il.com> Cc: laurent.pinchart@...asonboard.com, mchehab@...nel.org, gregkh@...uxfoundation.org, linux-media@...r.kernel.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drivers: staging: media: omap4iss: Use BIT macro instead of left shifting On Fri, Jan 21, 2022 at 10:37:22AM +0100, Moses Christopher Bollavarapu wrote: > There is a BIT(nr) macro available in Linux Kernel, > which does the same thing. > > Example: 1 << 7 is same as BIT(7) > > Signed-off-by: Moses Christopher Bollavarapu <mosescb.dev@...il.com> > --- > drivers/staging/media/omap4iss/iss_video.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/media/omap4iss/iss_video.h b/drivers/staging/media/omap4iss/iss_video.h > index 526281bf0051..ea1cc311384a 100644 > --- a/drivers/staging/media/omap4iss/iss_video.h > +++ b/drivers/staging/media/omap4iss/iss_video.h > @@ -55,17 +55,17 @@ enum iss_pipeline_state { > /* The stream has been started on the input video node. */ > ISS_PIPELINE_STREAM_INPUT = 1, This should be BIT(0). > /* The stream has been started on the output video node. */ > - ISS_PIPELINE_STREAM_OUTPUT = (1 << 1), > + ISS_PIPELINE_STREAM_OUTPUT = BIT(1), regards, dan carpenter
Powered by blists - more mailing lists