linux-kernel - Re: [PATCH] psi: Treat ksm swapping in copy as memstall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61ea820f.1c69fb81.e79d5.09c9@mx.google.com>
Date:   Fri, 21 Jan 2022 09:51:08 +0000
From:   CGEL <cgel.zte@...il.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     akpm@...ux-foundation.org, sfr@...b.auug.org.au,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Yang Yang <yang.yang29@....com.cn>
Subject: Re: [PATCH] psi: Treat ksm swapping in copy as memstall

 Wed, Jan 19, 2022 at 07:58:23AM -0500, Johannes Weiner wrote:
> On Wed, Jan 19, 2022 at 06:13:54AM +0000, CGEL wrote:
> > I did a test, when we use zram, it takes longer time for ksm copying than
> > swap_readpage(). Ksm copying average takes 147263ns, swap_readpage()
> > average takes 55639ns. So I think this patch is reasonable.
> 
> Ok, that sounds reasonable to me as well. Please add the
> PageWorkingset() check and resubmit the patch. Thanks!
I am a litte confused about adding PageWorkingset(), since I
think ksm_might_need_to_copy() memstall is like swap_readpage()
memstall and swap_readpage() doesn't add PageWorkingset().

Would please make it cleaner? Thanks!