linux-kernel - [PATCH 13/31] mmc: changing LED_* from enum led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220121165436.30956-14-sampaio.ime@gmail.com>
Date:   Fri, 21 Jan 2022 13:54:18 -0300
From:   Luiz Sampaio <sampaio.ime@...il.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>
Cc:     linux-kernel@...r.kernel.org, Luiz Sampaio <sampaio.ime@...il.com>,
        linux-mmc@...r.kernel.org
Subject: [PATCH 13/31] mmc: changing LED_* from enum led_brightness to actual value

The enum led_brightness, which contains the declaration of LED_OFF,
LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
max_brightness.
---
 drivers/mmc/core/core.c           | 4 ++--
 drivers/mmc/host/rtsx_usb_sdmmc.c | 4 ++--
 drivers/mmc/host/sdhci.c          | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 368f10405e13..66bc9c780e06 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -175,7 +175,7 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
 		mmc_should_fail_request(host, mrq);
 
 		if (!host->ongoing_mrq)
-			led_trigger_event(host->led, LED_OFF);
+			led_trigger_event(host->led, 0);
 
 		if (mrq->sbc) {
 			pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
@@ -352,7 +352,7 @@ int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
 	if (err)
 		return err;
 
-	led_trigger_event(host->led, LED_FULL);
+	led_trigger_event(host->led, 255);
 	__mmc_start_request(host, mrq);
 
 	return 0;
diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
index 5fe4528e296e..64fe7a75f401 100644
--- a/drivers/mmc/host/rtsx_usb_sdmmc.c
+++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
@@ -1287,7 +1287,7 @@ static void rtsx_usb_update_led(struct work_struct *work)
 	if (host->power_mode == MMC_POWER_OFF)
 		goto out;
 
-	if (host->led.brightness == LED_OFF)
+	if (host->led.brightness == 0)
 		rtsx_usb_turn_off_led(ucr);
 	else
 		rtsx_usb_turn_on_led(ucr);
@@ -1357,7 +1357,7 @@ static int rtsx_usb_sdmmc_drv_probe(struct platform_device *pdev)
 	snprintf(host->led_name, sizeof(host->led_name),
 		"%s::", mmc_hostname(mmc));
 	host->led.name = host->led_name;
-	host->led.brightness = LED_OFF;
+	host->led.brightness = 0;
 	host->led.default_trigger = mmc_hostname(mmc);
 	host->led.brightness_set = rtsx_usb_led_control;
 
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 07c6da1f2f0f..ddc58a8f0c4f 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -395,7 +395,7 @@ static void sdhci_led_control(struct led_classdev *led,
 	if (host->runtime_suspended)
 		goto out;
 
-	if (brightness == LED_OFF)
+	if (brightness == 0)
 		__sdhci_led_deactivate(host);
 	else
 		__sdhci_led_activate(host);
@@ -414,7 +414,7 @@ static int sdhci_led_register(struct sdhci_host *host)
 		 "%s::", mmc_hostname(mmc));
 
 	host->led.name = host->led_name;
-	host->led.brightness = LED_OFF;
+	host->led.brightness = 0;
 	host->led.default_trigger = mmc_hostname(mmc);
 	host->led.brightness_set = sdhci_led_control;
 
-- 
2.34.1