linux-kernel - Re: [PATCH 27/31] net: mac80211 : changing LED_* from enum led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25f2b7aad73e65a38c6203c400425c2489332dec.camel@sipsolutions.net>
Date:   Fri, 21 Jan 2022 20:28:44 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Luiz Sampaio <sampaio.ime@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 27/31] net: mac80211 : changing LED_* from enum
 led_brightness to actual value

On Fri, 2022-01-21 at 13:54 -0300, Luiz Sampaio wrote:
> The enum led_brightness, which contains the declaration of LED_OFF,
> LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
> max_brightness.
> 

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

and particularly

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_messages

would be a good thing to read.

Also, clearly you need to actually sign off your patches:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

(but yeah read the entire page)

Anyway, I'm with the other comments - what's the point in replacing
things like "LED_FULL" with arbitrary "255". I guess your commit message
should explain that, I don't see how it really is so obviously
"obsolete" that this needs no more comments.

johannes