linux-kernel - [cel:topic-rpc-with-tls 9991/9999] net/tls/ecdh.c:144:1: warning: no previous prototype for 'ttls_ecdh_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202201221357.AwLCo8LM-lkp@intel.com>
Date:   Sat, 22 Jan 2022 13:08:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alexander K <ak@...pesta-tech.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Chuck Lever <chuck.lever@...cle.com>
Subject: [cel:topic-rpc-with-tls 9991/9999] net/tls/ecdh.c:144:1: warning: no
 previous prototype for 'ttls_ecdh_read_params'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux topic-rpc-with-tls
head:   a72d5318846d67a7f3f5f2bcb4c0c09c4f8907d1
commit: a0a99a10f4f0e3e1e35e566687137669da78abcd [9991/9999] Port of Tempesta TLS handshakes to the Linux 5.10.68
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220122/202201221357.AwLCo8LM-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?id=a0a99a10f4f0e3e1e35e566687137669da78abcd
        git remote add cel git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux
        git fetch --no-tags cel topic-rpc-with-tls
        git checkout a0a99a10f4f0e3e1e35e566687137669da78abcd
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/tls/ecdh.c:144:1: warning: no previous prototype for 'ttls_ecdh_read_params' [-Wmissing-prototypes]
     144 | ttls_ecdh_read_params(TlsECDHCtx *ctx, const unsigned char **buf,
         | ^~~~~~~~~~~~~~~~~~~~~
--
   In file included from include/asm-generic/bug.h:5,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/random.h:10,
                    from net/tls/bignum.h:28,
                    from net/tls/error.c:25:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:169:50: warning: ordered comparison of pointer with null pointer [-Wextra]
     169 | #define virt_addr_valid(kaddr)  ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                  ^~
   include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
      78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/scatterlist.h:143:9: note: in expansion of macro 'BUG_ON'
     143 |         BUG_ON(!virt_addr_valid(buf));
         |         ^~~~~~
   include/linux/scatterlist.h:143:17: note: in expansion of macro 'virt_addr_valid'
     143 |         BUG_ON(!virt_addr_valid(buf));
         |                 ^~~~~~~~~~~~~~~
   net/tls/error.c: At top level:
>> net/tls/error.c:40:6: warning: no previous prototype for 'ttls_strerror' [-Wmissing-prototypes]
      40 | void ttls_strerror(int ret, char *buf, size_t buflen)
         |      ^~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for CRYPTO_SHA1_SSSE3
   Depends on CRYPTO && X86 && 64BIT
   Selected by
   - TLS_HANDSHAKE && NET && TLS
   WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES
   Depends on DISCONTIGMEM || NUMA
   Selected by
   - SINGLE_MEMORY_CHUNK && MMU


vim +/ttls_ecdh_read_params +144 net/tls/ecdh.c

   135	
   136	/**
   137	 * Read the ServerKeyExhange parameters (RFC 8422 5.4)
   138	 *	struct {
   139	 *		ECParameters	curve_params;
   140	 *		ECPoint		public;
   141	 *	} ServerECDHParams;
   142	 */
   143	int
 > 144	ttls_ecdh_read_params(TlsECDHCtx *ctx, const unsigned char **buf,
   145			      const unsigned char *end)
   146	{
   147		int r;
   148	
   149		if (!(ctx->grp = ttls_ecp_tls_read_group(buf, end - *buf)))
   150			return -EINVAL;
   151	
   152		/*
   153		 * Import a point from a TLS ECPoint record (RFC 8443 5.4)
   154		 *	struct {
   155		 *		opaque point <1..2^8-1>;
   156		 *	} ECPoint;
   157		 */
   158		if (!(r = ttls_ecdh_read_public(ctx, *buf, end - *buf)))
   159			*buf += end - *buf;
   160	
   161		return r;
   162	}
   163	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org