linux-kernel - Re: [PATCH v4 0/3] Enable named interrupt smbus-alert for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Jan 2022 14:05:34 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Christian Koenig <christian.koenig@....com>,
        Dmitry Osipenko <digetx@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jon Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH v4 0/3] Enable named interrupt smbus-alert for ACPI

On Sat, Jan 22, 2022 at 1:33 PM Akhil R <akhilrajeev@...dia.com> wrote:
>
> I2C - SMBus core drivers use named interrupts to support smbus_alert.
> As named interrupts are not available for ACPI based systems, it was
> required to change the i2c bus controller driver if to use smbus alert.
> These patches provide option for named interrupts in ACPI and  make the
> implementation similar to DT. This will enable use of interrupt named
> 'smbus-alert' in ACPI as well which will be taken during i2c adapter
> register.

I'm fine with the series,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
Maintainers can ask something else, though.

> v3->v4:
>   * Removed device_irq_get_byname()
>   * Updates in comments and document.
> v2->v3:
>   * Grammar/spelling corrections.
>   * Added description in function comments.
>   * Removed 'unlikely' from NULL check on 'name'
> v1->v2:
>   * Added firmware guide documentation for ACPI named interrupts
>   * Updates in function description comments
>
> Akhil R (3):
>   device property: Add fwnode_irq_get_byname
>   docs: firmware-guide: ACPI: Add named interrupt doc
>   i2c: smbus: Use device_*() functions instead of of_*()
>
>  Documentation/firmware-guide/acpi/enumeration.rst | 39 +++++++++++++++++++++++
>  drivers/base/property.c                           | 29 +++++++++++++++++
>  drivers/i2c/i2c-core-base.c                       |  2 +-
>  drivers/i2c/i2c-core-smbus.c                      | 10 +++---
>  drivers/i2c/i2c-smbus.c                           |  3 +-
>  include/linux/i2c-smbus.h                         |  6 ++--
>  include/linux/property.h                          |  1 +
>  7 files changed, 80 insertions(+), 10 deletions(-)
>
> --
> 2.7.4
>


-- 
With Best Regards,
Andy Shevchenko