| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220122195731.934494-21-ogabbay@kernel.org> Date: Sat, 22 Jan 2022 21:57:22 +0200 From: Oded Gabbay <ogabbay@...nel.org> To: linux-kernel@...r.kernel.org Cc: Tomer Tayar <ttayar@...ana.ai> Subject: [PATCH 21/30] habanalabs: add missing error check in sysfs clk_freq_mhz_show From: Tomer Tayar <ttayar@...ana.ai> Add a missing error check in the sysfs show functions for clk_max_freq_mhz and clk_cur_freq_mhz_show. Signed-off-by: Tomer Tayar <ttayar@...ana.ai> Reviewed-by: Oded Gabbay <ogabbay@...nel.org> Signed-off-by: Oded Gabbay <ogabbay@...nel.org> --- drivers/misc/habanalabs/common/sysfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/misc/habanalabs/common/sysfs.c b/drivers/misc/habanalabs/common/sysfs.c index 3f220dd3b6b2..c665a3ac8876 100644 --- a/drivers/misc/habanalabs/common/sysfs.c +++ b/drivers/misc/habanalabs/common/sysfs.c @@ -18,6 +18,8 @@ static ssize_t clk_max_freq_mhz_show(struct device *dev, struct device_attribute return -ENODEV; value = hl_fw_get_frequency(hdev, hdev->asic_prop.clk_pll_index, false); + if (value < 0) + return value; hdev->asic_prop.max_freq_value = value; @@ -59,6 +61,8 @@ static ssize_t clk_cur_freq_mhz_show(struct device *dev, struct device_attribute return -ENODEV; value = hl_fw_get_frequency(hdev, hdev->asic_prop.clk_pll_index, true); + if (value < 0) + return value; return sprintf(buf, "%lu\n", (value / 1000 / 1000)); } -- 2.25.1
Powered by blists - more mailing lists