linux-kernel - Re: [PATCH] tools/perf: remove redundant err variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Jan 2022 17:26:34 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     cgel.zte@...il.com
Cc:     mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] tools/perf: remove redundant err variable

Em Wed, Jan 12, 2022 at 08:01:09AM +0000, cgel.zte@...il.com escreveu:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value from perf_event__process_tracing_data() directly instead
> of taking this in another redundant variable.

Thanks, applied.

- Arnaldo

 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> ---
>  tools/perf/builtin-inject.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
> index 409b721666cb..fbf43a454cba 100644
> --- a/tools/perf/builtin-inject.c
> +++ b/tools/perf/builtin-inject.c
> @@ -535,12 +535,9 @@ static int perf_event__repipe_exit(struct perf_tool *tool,
>  static int perf_event__repipe_tracing_data(struct perf_session *session,
>  					   union perf_event *event)
>  {
> -	int err;
> -
>  	perf_event__repipe_synth(session->tool, event);
> -	err = perf_event__process_tracing_data(session, event);
>  
> -	return err;
> +	return perf_event__process_tracing_data(session, event);
>  }
>  
>  static int dso__read_build_id(struct dso *dso)
> -- 
> 2.25.1

-- 

- Arnaldo