linux-kernel - Re: [PATCH] Bugfix RTS line config in RS485 mode is overwritten in pl011_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220123043258.GA21313@wunner.de>
Date:   Sun, 23 Jan 2022 05:32:58 +0100
From:   Lukas Wunner <lukas@...ner.de>
To:     Jochen Mades <jochen@...es.net>
Cc:     gregkh@...uxfoundation.org, Russell King <linux@...linux.org.uk>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lino Sanfilippo <LinoSanfilippo@....de>,
        Philipp Rosenberger <p.rosenberger@...bus.com>
Subject: Re: [PATCH] Bugfix RTS line config in RS485 mode is overwritten in
 pl011_set_mctrl() function.

On Thu, Jan 13, 2022 at 11:12:12AM +0100, Jochen Mades wrote:
> Find attached the patch with the new subject and corretced commit message.

Greg doesn't accept patches as attachments and during the merge window
(which ends today).  I've just resubmitted your patch as part of a
2-patch series, together with a patch of mine which goes on top of yours:

https://lore.kernel.org/linux-serial/85fa3323ba8c307943969b7343e23f34c3e652ba.1642909284.git.lukas@wunner.de/

(I sent your patch twice because I botched the Date header the first time
around, sorry about that.)

Note that you still get patch authorship (and thus credit for the patch)
even though I submitted it, due to the From: line at the top of the
message body.

> > * Add tags for the offending commit:
> > 
> >   Fixes: 8d479237727c ("serial: amba-pl011: add RS485 support")
> >   Cc: stable@...r.kernel.org # v5.15+
> > 
> > * Be sure to cc the author of the offending commit.
> 
> Sorry I don't know how to do that correctly. Can you please give support/hints?

It just means that you need to add the two above-quoted tags to the
commit message.  The maintainers of stable kernels use them to
determine which patches need to be backported to which kernel
releases.  I've fixed up the commit message of your patch with
the missing tags, no problem.

And "cc the author of the offending commit" just means that when
posting the patch, it is customary to send a copy of the e-mail
to the author of the commit you're fixing, which is Lino in this
case, as he authored 8d479237727c.

Thanks,

Lukas