linux-kernel - [PATCH] drm: add missing dependency to DRM_PANEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Jan 2022 21:43:23 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     dri-devel@...ts.freedesktop.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, Luca Weiss <luca@...tu.xyz>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org
Subject: [PATCH] drm: add missing dependency to DRM_PANEL_EDP

With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation
fails:

  drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to `drm_panel_dp_aux_backlight'

Add a dependency on DRM_KMS_HELPER to fix this.

Signed-off-by: Luca Weiss <luca@...tu.xyz>
---
I briefly tried "select DRM_KMS_HELPER" but that causes a circular
dependency.
If someone has a better idea how to solve this, feel free correct me.

 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 434c2861bb40..fda97837ecb3 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE
 config DRM_PANEL_EDP
 	tristate "support for simple Embedded DisplayPort panels"
 	depends on OF
+	depends on DRM_KMS_HELPER
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on PM
 	select VIDEOMODE_HELPERS
-- 
2.34.1