[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220123225717.1069538-1-ztong0001@gmail.com>
Date: Sun, 23 Jan 2022 14:57:17 -0800
From: Tong Zhang <ztong0001@...il.com>
To: Hannes Reinecke <hare@...nel.org>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Tong Zhang <ztong0001@...il.com>
Subject: [PATCH v1] scsi: myrs: fix crash on error case
In myrs_detect(), cs->disable_intr is NULL when privdata->hw_init() fail
with non-zero. In this case, myrs_cleanup(cs) will call a NULL ptr and
crash kernel.
[ 1.105606] myrs 0000:00:03.0: Unknown Initialization Error 5A
[ 1.105872] myrs 0000:00:03.0: Failed to initialize Controller
[ 1.106082] BUG: kernel NULL pointer dereference, address: 0000000000000000
[ 1.110774] Call Trace:
[ 1.110950] myrs_cleanup+0xe4/0x150 [myrs]
[ 1.111135] myrs_probe.cold+0x91/0x56a [myrs]
[ 1.111302] ? DAC960_GEM_intr_handler+0x1f0/0x1f0 [myrs]
[ 1.111500] local_pci_probe+0x48/0x90
Signed-off-by: Tong Zhang <ztong0001@...il.com>
---
drivers/scsi/myrs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
index 253ceca54a84..7eb8c39da366 100644
--- a/drivers/scsi/myrs.c
+++ b/drivers/scsi/myrs.c
@@ -2267,7 +2267,8 @@ static void myrs_cleanup(struct myrs_hba *cs)
myrs_unmap(cs);
if (cs->mmio_base) {
- cs->disable_intr(cs);
+ if (cs->disable_intr)
+ cs->disable_intr(cs);
iounmap(cs->mmio_base);
cs->mmio_base = NULL;
}
--
2.25.1
Powered by blists - more mailing lists