linux-kernel - Re: [PATCH net-next] net-core: add InMacErrors counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKGOw3LZ_2agxewuNLMLRX7TSnGYnf0T6NwC+1s4OB2bg@mail.gmail.com>
Date:   Mon, 24 Jan 2022 09:39:22 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Brian Vazquez <brianvv@...gle.com>,
        Jeffrey Ji <jeffreyjilinux@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        LKML <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>, jeffreyji <jeffreyji@...gle.com>
Subject: Re: [PATCH net-next] net-core: add InMacErrors counter

On Mon, Jan 24, 2022 at 9:29 AM Jakub Kicinski <kuba@...nel.org> wrote:

> That much it's understood, but it's a trade off. This drop point
> existed for 20 years, why do we need to consume extra memory now?

Being able to tell after the facts, that such a drop reason had
occured can help investigations.

nstat -a | grep InMac

Jeffrey, what about _also_ adding the kfree_skb_reason(), since this
seems to also help ?