lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jan 2022 08:39:16 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: ratnesh-r1 <me.ratnesh682@...il.com> Cc: devel@...verdev.osuosl.org, Todd Kjos <tkjos@...roid.com>, linux-kernel@...r.kernel.org, Arve Hjønnevåg <arve@...roid.com>, Joel Fernandes <joel@...lfernandes.org>, Martijn Coenen <maco@...roid.com>, Christian Brauner <christian@...uner.io> Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword On Sun, Jan 23, 2022 at 11:09:47PM -0800, ratnesh-r1 wrote: > warning found by checkpatch.pl script. > > Signed-off-by: ratnesh-r1 <me.ratnesh682@...il.com> > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index c05a214..f9cfa15 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@...uxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch breaks the build. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
Powered by blists - more mailing lists