lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Jan 2022 17:54:09 -0800 From: ira.weiny@...el.com To: David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Patrik Jakobsson <patrik.r.jakobsson@...il.com>, Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run> Cc: Ira Weiny <ira.weiny@...el.com>, amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org Subject: [PATCH V2 7/7] drm/radeon: Ensure kunmap is called on error From: Ira Weiny <ira.weiny@...el.com> The default case leaves the buffer object mapped in error. Add radeon_bo_kunmap() to that case to ensure the mapping is cleaned up. Signed-off-by: Ira Weiny <ira.weiny@...el.com> --- NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug. --- drivers/gpu/drm/radeon/radeon_uvd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c index 377f9cdb5b53..7cca283f6202 100644 --- a/drivers/gpu/drm/radeon/radeon_uvd.c +++ b/drivers/gpu/drm/radeon/radeon_uvd.c @@ -560,6 +560,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo, default: + radeon_bo_kunmap(bo); DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type); return -EINVAL; } -- 2.31.1
Powered by blists - more mailing lists