linux-kernel - Re: [PATCH rdma-next 10/11] RDMA/iser: Delete useless module.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jan 2022 02:18:27 +0200
From:   Max Gurtovoy <mgurtovoy@...dia.com>
To:     Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...dia.com>
CC:     Leon Romanovsky <leonro@...dia.com>,
        Christian Benvenuti <benve@...co.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        <linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Nelson Escobar <neescoba@...co.com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Yishai Hadas <yishaih@...dia.com>,
        "Zhu Yanjun" <zyjzyj2000@...il.com>
Subject: Re: [PATCH rdma-next 10/11] RDMA/iser: Delete useless module.h
 include


On 1/23/2022 8:02 PM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
>
> There is no need in include of module.h in the following files.
>
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
>   drivers/infiniband/ulp/iser/iser_memory.c | 1 -
>   drivers/infiniband/ulp/iser/iser_verbs.c  | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/iser/iser_memory.c b/drivers/infiniband/ulp/iser/iser_memory.c
> index 660982625488..f1fd05d8609d 100644
> --- a/drivers/infiniband/ulp/iser/iser_memory.c
> +++ b/drivers/infiniband/ulp/iser/iser_memory.c
> @@ -30,7 +30,6 @@
>    * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
>    * SOFTWARE.
>    */
> -#include <linux/module.h>
>   #include <linux/kernel.h>
>   #include <linux/slab.h>
>   #include <linux/mm.h>
> diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c
> index 8bf87b073d9b..8893bc27d8f5 100644
> --- a/drivers/infiniband/ulp/iser/iser_verbs.c
> +++ b/drivers/infiniband/ulp/iser/iser_verbs.c
> @@ -32,7 +32,6 @@
>    * SOFTWARE.
>    */
>   #include <linux/kernel.h>
> -#include <linux/module.h>
>   #include <linux/slab.h>
>   #include <linux/delay.h>
>   

Looks good thanks,

Acked-by: Max Gurtovoy <mgurtovoy@...dia.com>