linux-kernel - Re: [PATCH 02/11] serial: atmel_serial: include circ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9504cb7-817d-9e50-1669-51e97d3e4347@posteo.net>
Date:   Mon, 24 Jan 2022 08:49:37 +0000
From:   Richard Genoud <richard.genoud@...il.com>
To:     Jiri Slaby <jslaby@...e.cz>, gregkh@...uxfoundation.org
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        johan@...nel.org, Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Richard Genoud <richard.genoud@...il.com>
Subject: Re: [PATCH 02/11] serial: atmel_serial: include circ_buf.h

Le 24/01/2022 à 09:46, Richard Genoud a écrit :
> 
> Le 24/01/2022 à 08:14, Jiri Slaby a écrit :
>> atmel_uart_port::rx_ring is defined as struct circ_buf, but circ_buf.h
>> is not included explicitly in atmel_serial.c. It is included only
>> implicitly via serial_core.h. Fix this as serial_core.h might not
>> include that header in the future.
>>
>> Signed-off-by:Jiri Slaby <jslaby@...e.cz>
>> Cc: Richard Genoud <richard.genoud@...il.com>
>> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
>> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
>> Cc: Ludovic Desroches <ludovic.desroches@...rochip.com>

Sorry, I really meant acked-by, not Signed-off-by :
Acked-by: Richard Genoud <richard.genoud@...il.com>

>> ---
>>   drivers/tty/serial/atmel_serial.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
>> index c370eddc651b..2d09a89974a2 100644
>> --- a/drivers/tty/serial/atmel_serial.c
>> +++ b/drivers/tty/serial/atmel_serial.c
>> @@ -8,6 +8,7 @@
>>    *
>>    *  DMA support added by Chip Coldwell.
>>    */
>> +#include <linux/circ_buf.h>
>>   #include <linux/tty.h>
>>   #include <linux/ioport.h>
>>   #include <linux/slab.h>
Thanks !