linux-kernel - Re: [PATCH -next] exit: export make_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ye5vR609miJCKdYa@infradead.org>
Date:   Mon, 24 Jan 2022 01:20:07 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        linux-ia64@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH -next] exit: export make_task_dead()

On Sat, Jan 22, 2022 at 09:48:34AM -0800, Randy Dunlap wrote:
> In a config file from "kernel test robot <lkp@...el.com>" for a
> different problem, this linker error was exposed when
> CONFIG_IA64_MCA_RECOVERY=m.
> 
> We could either export make_task_dead() or restrict IA64_MCA_RECOVERY
> to a bool Kconfig symbol instead of a tristate symbol, so go with the
> EXPORT_SYMBOL() path.
> 
> Fixes this build error:
> 
> ERROR: modpost: "make_task_dead" [arch/ia64/kernel/mca_recovery.ko] undefined!
> 
> Fixes: 0e25498f8cd4 ("exit: Add and use make_task_dead.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> Cc: linux-ia64@...r.kernel.org
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: kernel test robot <lkp@...el.com>
> ---
>  kernel/exit.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20220121.orig/kernel/exit.c
> +++ linux-next-20220121/kernel/exit.c
> @@ -896,6 +896,7 @@ void __noreturn make_task_dead(int signr
>  
>  	do_exit(signr);
>  }
> +EXPORT_SYMBOL(make_task_dead);

EXPORT_SYMBOL_GPL and restricted, please.

Or even better: force the mca recovery code to be built in.