lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jan 2022 01:29:57 -0800 From: Christoph Hellwig <hch@...radead.org> To: Lu Baolu <baolu.lu@...ux.intel.com> Cc: Joerg Roedel <joro@...tes.org>, Jason Gunthorpe <jgg@...dia.com>, Christoph Hellwig <hch@...radead.org>, Ben Skeggs <bskeggs@...hat.com>, Kevin Tian <kevin.tian@...el.com>, Ashok Raj <ashok.raj@...el.com>, Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>, Alex Williamson <alex.williamson@...hat.com>, Eric Auger <eric.auger@...hat.com>, Liu Yi L <yi.l.liu@...el.com>, Jacob jun Pan <jacob.jun.pan@...el.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 5/7] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain On Mon, Jan 24, 2022 at 03:11:00PM +0800, Lu Baolu wrote: > The supported page sizes of an iommu_domain are saved in the pgsize_bitmap > field. Retrieve the value from the right place. > > Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com> > Reviewed-by: Robin Murphy <robin.murphy@....com> > Link: https://lore.kernel.org/r/20211218074546.1772553-1-baolu.lu@linux.intel.com Looks good: Reviewed-by: Christoph Hellwig <hch@....de> Wouldn't it mke sense to remove the pgsize_bitmap in struct iommu_ops and initialize the domain field in the domain_alloc methods? Or am I missing something?
Powered by blists - more mailing lists