linux-kernel - Re: [PATCH] pcmcia: db1xxx_ss: restrict to MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOLZvyH1UTf4e94xa-yF2CasqOCbyCOz5YZEs9QjLBOyVipt4A@mail.gmail.com>
Date:   Mon, 24 Jan 2022 10:45:36 +0100
From:   Manuel Lauss <manuel.lauss@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Arnd Bergmann <arnd@...db.de>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Kees Cook <keescook@...omium.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Linux-MIPS <linux-mips@...r.kernel.org>
Subject: Re: [PATCH] pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards

Hello,

On Sun, Jan 23, 2022 at 6:40 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of
> MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due
> to missing DB1XXX symbols. The PCMCIA driver should be restricted
> to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error.

>  config PCMCIA_ALCHEMY_DEVBOARD
>         tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
> -       depends on MIPS_ALCHEMY && PCMCIA
> +       depends on MIPS_DB1XXX && PCMCIA
>         help
>           Enable this driver of you want PCMCIA support on your Alchemy
>           Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300

Seems sensible.
Acked-by: Manuel Lauss <manuel.lauss@...il.com>

Thank you!
      Manuel