linux-kernel - Re: [PATCH v1] scsi: myrs: fix crash on error case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164308927349.18787.5117723366670318865.b4-ty@oracle.com>
Date:   Tue, 25 Jan 2022 00:41:31 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Tong Zhang <ztong0001@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, Hannes Reinecke <hare@...nel.org>,
        linux-kernel@...r.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v1] scsi: myrs: fix crash on error case

On Sun, 23 Jan 2022 14:57:17 -0800, Tong Zhang wrote:

> In myrs_detect(), cs->disable_intr is NULL when privdata->hw_init() fail
> with non-zero. In this case, myrs_cleanup(cs) will call a NULL ptr and
> crash kernel.
> 
> [    1.105606] myrs 0000:00:03.0: Unknown Initialization Error 5A
> [    1.105872] myrs 0000:00:03.0: Failed to initialize Controller
> [    1.106082] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [    1.110774] Call Trace:
> [    1.110950]  myrs_cleanup+0xe4/0x150 [myrs]
> [    1.111135]  myrs_probe.cold+0x91/0x56a [myrs]
> [    1.111302]  ? DAC960_GEM_intr_handler+0x1f0/0x1f0 [myrs]
> [    1.111500]  local_pci_probe+0x48/0x90
> 
> [...]

Applied to 5.17/scsi-fixes, thanks!

[1/1] scsi: myrs: fix crash on error case
      https://git.kernel.org/mkp/scsi/c/4db09593af0b

-- 
Martin K. Petersen	Oracle Linux Engineering