linux-kernel - Re: [PATCH 5.16 0728/1039] scripts: sphinx-pre-install: Fix ctex support on Debian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220125091551.6a6faaf6@coco.lan>
Date:   Tue, 25 Jan 2022 09:15:51 +0100
From:   Mauro Carvalho Chehab <mchehab@...nel.org>
To:     Akira Yokosawa <akiyks@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jonathan Corbet <corbet@....net>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.16 0728/1039] scripts: sphinx-pre-install: Fix ctex
 support on Debian

Em Tue, 25 Jan 2022 07:48:39 +0900
Akira Yokosawa <akiyks@...il.com> escreveu:

> Hi Greg,
> 
> On Mon, 24 Jan 2022 19:41:57 +0100,
> Greg Kroah-Hartman wrote:
> > From: Mauro Carvalho Chehab <mchehab@...nel.org>
> > 
> > [ Upstream commit 87d6576ddf8ac25f36597bc93ca17f6628289c16 ]
> > 
> > The name of the package with ctexhook.sty is different on
> > Debian/Ubuntu.
> > 
> > Reported-by: Akira Yokosawa <akiyks@...il.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>
> > Tested-by: Akira Yokosawa <akiyks@...il.com>
> > Link: https://lore.kernel.org/r/63882425609a2820fac78f5e94620abeb7ed5f6f.1641429634.git.mchehab@kernel.org
> > Signed-off-by: Jonathan Corbet <corbet@....net>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>  
> 
> This "Fix" is against upstream commit 7baab965896e ("scripts:
> sphinx-pre-install: add required ctex dependency") which is
> also new to v5.17-rc1.
> 
> So I don't think this is worth backporting to stable branches.

Well, either both patches should be backported or none, IMHO.
I guess I would just backport also commit 7baab965896e.

> 
>         Thanks, Akira
> 
> > ---
> >  scripts/sphinx-pre-install | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/scripts/sphinx-pre-install b/scripts/sphinx-pre-install
> > index 288e86a9d1e58..61a79ce705ccf 100755
> > --- a/scripts/sphinx-pre-install
> > +++ b/scripts/sphinx-pre-install
> > @@ -369,6 +369,9 @@ sub give_debian_hints()
> >  	);
> >  
> >  	if ($pdf) {
> > +		check_missing_file(["/usr/share/texlive/texmf-dist/tex/latex/ctex/ctexhook.sty"],
> > +				   "texlive-lang-chinese", 2);
> > +
> >  		check_missing_file(["/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf"],
> >  				   "fonts-dejavu", 2);
> >    



Thanks,
Mauro