linux-kernel - Re: [PATCH v9] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jan 2022 11:02:04 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Sun Shouxin <sunshouxin@...natelecom.cn>, <j.vosburgh@...il.com>,
        <vfalico@...il.com>, <andy@...yhouse.net>, <davem@...emloft.net>,
        <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <jay.vosburgh@...onical.com>, <huyd12@...natelecom.cn>
Subject: Re: [PATCH v9] net: bonding: Add support for IPV6 ns/na to
 balance-alb/balance-tlb mode

On 25/01/2022 10:51, Nikolay Aleksandrov wrote:
> On 25/01/2022 04:37, Sun Shouxin wrote:
>> Since ipv6 neighbor solicitation and advertisement messages
>> isn't handled gracefully in bond6 driver, we can see packet
>> drop due to inconsistency between mac address in the option
>> message and source MAC .
>>
>> Another examples is ipv6 neighbor solicitation and advertisement
>> messages from VM via tap attached to host bridge, the src mac
>> might be changed through balance-alb mode, but it is not synced
>> with Link-layer address in the option message.
>>
>> The patch implements bond6's tx handle for ipv6 neighbor
>> solicitation and advertisement messages.
>>
>> Suggested-by: Hu Yadi <huyd12@...natelecom.cn>
>> Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>
>> Signed-off-by: Sun Shouxin <sunshouxin@...natelecom.cn>
>> ---
>>  drivers/net/bonding/bond_alb.c | 38 +++++++++++++++++++++++++++++++++-
>>  1 file changed, 37 insertions(+), 1 deletion(-)
>>
[snip]

Also forgot to mention, you should add a changelog between patch versions.
You can add it below the --- marker so it won't be included in the commit
message. Otherwise it's hard to track how the patch reached v9 and what
changed between versions.

E.g. v8 -> v9: <changed blah>

Thanks,
 Nik