linux-kernel - Re: [PATCH v3 4/4] Watchdog: sp5100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220125134354.4db24118@endymion>
Date:   Tue, 25 Jan 2022 13:43:54 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Terry Bowman <terry.bowman@....com>
Cc:     <linux@...ck-us.net>, <linux-watchdog@...r.kernel.org>,
        <linux-i2c@...r.kernel.org>, <wsa@...nel.org>,
        <andy.shevchenko@...il.com>, <rafael.j.wysocki@...el.com>,
        <linux-kernel@...r.kernel.org>, <wim@...ux-watchdog.org>,
        <rrichter@....com>, <thomas.lendacky@....com>,
        <Nehal-bakulchandra.Shah@....com>, <Basavaraj.Natikar@....com>,
        <Shyam-sundar.S-k@....com>, <Mario.Limonciello@....com>
Subject: Re: [PATCH v3 4/4] Watchdog: sp5100_tco: Enable Family 17h+ CPUs

Hi Terry,

On Tue, 18 Jan 2022 14:22:34 -0600, Terry Bowman wrote:
> The driver currently uses a CPU family match of 17h to determine
> EFCH_PM_DECODEEN_WDT_TMREN register support. This family check will not
> support future AMD CPUs and instead will require driver updates to add
> support.
> 
> Remove the family 17h family check and add a check for SMBus PCI
> revision ID 0x51 or greater. The MMIO access method has been available
> since at least SMBus controllers using PCI revision 0x51. This revision
> check will support family 17h and future AMD processors including EFCH
> functionality without requiring driver changes.
> 
> Co-developed-by: Robert Richter <rrichter@....com>
> Signed-off-by: Robert Richter <rrichter@....com>
> Signed-off-by: Terry Bowman <terry.bowman@....com>
> To: Guenter Roeck <linux@...ck-us.net>
> To: linux-watchdog@...r.kernel.org
> To: Jean Delvare <jdelvare@...e.com>
> To: linux-i2c@...r.kernel.org
> To: Wolfram Sang <wsa@...nel.org>
> To: Andy Shevchenko <andy.shevchenko@...il.com>
> To: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Robert Richter <rrichter@....com>
> Cc: Thomas Lendacky <thomas.lendacky@....com>
> ---
>  drivers/watchdog/sp5100_tco.c | 16 ++++------------
>  drivers/watchdog/sp5100_tco.h |  1 +
>  2 files changed, 5 insertions(+), 12 deletions(-)
> (...)

Looks good to me.

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support