linux-kernel - Re: [PATCH 1/6] clk: imx6ul: disable gpmi_io clock before changing parent clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jan 2022 10:11:17 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Christian Eggers <ceggers@...i.de>
Cc:     Abel Vesa <abel.vesa@....com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-clk <linux-clk@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stefan Riedmueller <s.riedmueller@...tec.de>
Subject: Re: [PATCH 1/6] clk: imx6ul: disable gpmi_io clock before changing
 parent clock

Hi Christian,

On Tue, Jan 25, 2022 at 5:53 AM Christian Eggers <ceggers@...i.de> wrote:
>
> gpmi_io clock may have been enabled by the boot loader. All children of
> enfc_clk_root must be gated in order to prevent glitches during parent
> change.
>
> Signed-off-by: Christian Eggers <ceggers@...i.de>
> ---
> drivers/clk/imx/clk-imx6ul.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> index 520b100bff4b..f599ae50dd9f 100644
> --- a/drivers/clk/imx/clk-imx6ul.c
> +++ b/drivers/clk/imx/clk-imx6ul.c
> @@ -514,6 +514,15 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
> else if (clk_on_imx6ull())
> clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk);
>
> + /*
> + * gpmi_io clock may have been enabled by the boot loader. All children of
> + * enfc_clk_root must be gated in order to prevent glitches during parent
> + * change. The task of re-enabling is left to the gpmi-nand driver.
> + */
> + if (clk_hw_is_enabled(hws[IMX6UL_CLK_GPMI_IO])) {
> + clk_prepare_enable(hws[IMX6UL_CLK_GPMI_IO]->clk);
> + clk_disable_unprepare(hws[IMX6UL_CLK_GPMI_IO]->clk);
> + }

It seems your patch series was corrupted.

Could you please try sending it via git send-mail?