| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202201252130.U4qxBhmg-lkp@intel.com>
Date: Tue, 25 Jan 2022 21:31:32 +0800
From: kernel test robot <lkp@...el.com>
To: Iwona Winiarska <iwona.winiarska@...el.com>,
linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: kbuild-all@...ts.01.org, devicetree@...r.kernel.org,
linux-aspeed@...ts.ozlabs.org,
linux-arm-kernel@...ts.infradead.org, linux-hwmon@...r.kernel.org,
linux-doc@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Joel Stanley <joel@....id.au>
Subject: Re: [PATCH v6 05/13] peci: Add peci-aspeed controller driver
Hi Iwona,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on linux/master linus/master v5.17-rc1 next-20220125]
[cannot apply to joel-aspeed/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Iwona-Winiarska/Introduce-PECI-subsystem/20220125-115946
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220125/202201252130.U4qxBhmg-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/35075a61a26913806122a9b500915dc66ad678bd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Iwona-Winiarska/Introduce-PECI-subsystem/20220125-115946
git checkout 35075a61a26913806122a9b500915dc66ad678bd
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> drivers/clk/clk.c:856:6: error: redefinition of 'clk_unprepare'
856 | void clk_unprepare(struct clk *clk)
| ^~~~~~~~~~~~~
In file included from drivers/clk/clk.c:9:
include/linux/clk.h:303:20: note: previous definition of 'clk_unprepare' with type 'void(struct clk *)'
303 | static inline void clk_unprepare(struct clk *clk)
| ^~~~~~~~~~~~~
>> drivers/clk/clk.c:937:5: error: redefinition of 'clk_prepare'
937 | int clk_prepare(struct clk *clk)
| ^~~~~~~~~~~
In file included from drivers/clk/clk.c:9:
include/linux/clk.h:271:19: note: previous definition of 'clk_prepare' with type 'int(struct clk *)'
271 | static inline int clk_prepare(struct clk *clk)
| ^~~~~~~~~~~
>> drivers/clk/clk.c:1183:6: error: redefinition of 'clk_is_enabled_when_prepared'
1183 | bool clk_is_enabled_when_prepared(struct clk *clk)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/clk/clk.c:9:
include/linux/clk.h:284:20: note: previous definition of 'clk_is_enabled_when_prepared' with type 'bool(struct clk *)' {aka '_Bool(struct clk *)'}
284 | static inline bool clk_is_enabled_when_prepared(struct clk *clk)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for COMMON_CLK
Depends on !HAVE_LEGACY_CLK
Selected by
- PECI_ASPEED && PECI && (ARCH_ASPEED || COMPILE_TEST && OF && HAS_IOMEM
vim +/clk_unprepare +856 drivers/clk/clk.c
a6adc30ba7bef8 Dong Aisheng 2016-06-30 844
4dff95dc9477a3 Stephen Boyd 2015-04-30 845 /**
4dff95dc9477a3 Stephen Boyd 2015-04-30 846 * clk_unprepare - undo preparation of a clock source
4dff95dc9477a3 Stephen Boyd 2015-04-30 847 * @clk: the clk being unprepared
4dff95dc9477a3 Stephen Boyd 2015-04-30 848 *
4dff95dc9477a3 Stephen Boyd 2015-04-30 849 * clk_unprepare may sleep, which differentiates it from clk_disable. In a
4dff95dc9477a3 Stephen Boyd 2015-04-30 850 * simple case, clk_unprepare can be used instead of clk_disable to gate a clk
4dff95dc9477a3 Stephen Boyd 2015-04-30 851 * if the operation may sleep. One example is a clk which is accessed over
4dff95dc9477a3 Stephen Boyd 2015-04-30 852 * I2c. In the complex case a clk gate operation may require a fast and a slow
4dff95dc9477a3 Stephen Boyd 2015-04-30 853 * part. It is this reason that clk_unprepare and clk_disable are not mutually
4dff95dc9477a3 Stephen Boyd 2015-04-30 854 * exclusive. In fact clk_disable must be called before clk_unprepare.
4dff95dc9477a3 Stephen Boyd 2015-04-30 855 */
4dff95dc9477a3 Stephen Boyd 2015-04-30 @856 void clk_unprepare(struct clk *clk)
b2476490ef1113 Mike Turquette 2012-03-15 857 {
4dff95dc9477a3 Stephen Boyd 2015-04-30 858 if (IS_ERR_OR_NULL(clk))
4dff95dc9477a3 Stephen Boyd 2015-04-30 859 return;
b2476490ef1113 Mike Turquette 2012-03-15 860
a6adc30ba7bef8 Dong Aisheng 2016-06-30 861 clk_core_unprepare_lock(clk->core);
1e435256d625c2 Olof Johansson 2013-04-27 862 }
4dff95dc9477a3 Stephen Boyd 2015-04-30 863 EXPORT_SYMBOL_GPL(clk_unprepare);
1e435256d625c2 Olof Johansson 2013-04-27 864
4dff95dc9477a3 Stephen Boyd 2015-04-30 865 static int clk_core_prepare(struct clk_core *core)
4dff95dc9477a3 Stephen Boyd 2015-04-30 866 {
4dff95dc9477a3 Stephen Boyd 2015-04-30 867 int ret = 0;
b2476490ef1113 Mike Turquette 2012-03-15 868
a63347251907d7 Stephen Boyd 2015-05-06 869 lockdep_assert_held(&prepare_lock);
a63347251907d7 Stephen Boyd 2015-05-06 870
4dff95dc9477a3 Stephen Boyd 2015-04-30 871 if (!core)
4dff95dc9477a3 Stephen Boyd 2015-04-30 872 return 0;
b2476490ef1113 Mike Turquette 2012-03-15 873
4dff95dc9477a3 Stephen Boyd 2015-04-30 874 if (core->prepare_count == 0) {
9a34b45397e5a3 Marek Szyprowski 2017-08-21 875 ret = clk_pm_runtime_get(core);
4dff95dc9477a3 Stephen Boyd 2015-04-30 876 if (ret)
4dff95dc9477a3 Stephen Boyd 2015-04-30 877 return ret;
b2476490ef1113 Mike Turquette 2012-03-15 878
9a34b45397e5a3 Marek Szyprowski 2017-08-21 879 ret = clk_core_prepare(core->parent);
9a34b45397e5a3 Marek Szyprowski 2017-08-21 880 if (ret)
9a34b45397e5a3 Marek Szyprowski 2017-08-21 881 goto runtime_put;
9a34b45397e5a3 Marek Szyprowski 2017-08-21 882
4dff95dc9477a3 Stephen Boyd 2015-04-30 883 trace_clk_prepare(core);
1c155b3dfe0835 Ulf Hansson 2013-03-12 884
4dff95dc9477a3 Stephen Boyd 2015-04-30 885 if (core->ops->prepare)
4dff95dc9477a3 Stephen Boyd 2015-04-30 886 ret = core->ops->prepare(core->hw);
1c155b3dfe0835 Ulf Hansson 2013-03-12 887
4dff95dc9477a3 Stephen Boyd 2015-04-30 888 trace_clk_prepare_complete(core);
b2476490ef1113 Mike Turquette 2012-03-15 889
9a34b45397e5a3 Marek Szyprowski 2017-08-21 890 if (ret)
9a34b45397e5a3 Marek Szyprowski 2017-08-21 891 goto unprepare;
b2476490ef1113 Mike Turquette 2012-03-15 892 }
b2476490ef1113 Mike Turquette 2012-03-15 893
4dff95dc9477a3 Stephen Boyd 2015-04-30 894 core->prepare_count++;
b2476490ef1113 Mike Turquette 2012-03-15 895
9461f7b33d11cb Jerome Brunet 2018-06-19 896 /*
9461f7b33d11cb Jerome Brunet 2018-06-19 897 * CLK_SET_RATE_GATE is a special case of clock protection
9461f7b33d11cb Jerome Brunet 2018-06-19 898 * Instead of a consumer claiming exclusive rate control, it is
9461f7b33d11cb Jerome Brunet 2018-06-19 899 * actually the provider which prevents any consumer from making any
9461f7b33d11cb Jerome Brunet 2018-06-19 900 * operation which could result in a rate change or rate glitch while
9461f7b33d11cb Jerome Brunet 2018-06-19 901 * the clock is prepared.
9461f7b33d11cb Jerome Brunet 2018-06-19 902 */
9461f7b33d11cb Jerome Brunet 2018-06-19 903 if (core->flags & CLK_SET_RATE_GATE)
9461f7b33d11cb Jerome Brunet 2018-06-19 904 clk_core_rate_protect(core);
9461f7b33d11cb Jerome Brunet 2018-06-19 905
4dff95dc9477a3 Stephen Boyd 2015-04-30 906 return 0;
9a34b45397e5a3 Marek Szyprowski 2017-08-21 907 unprepare:
9a34b45397e5a3 Marek Szyprowski 2017-08-21 908 clk_core_unprepare(core->parent);
9a34b45397e5a3 Marek Szyprowski 2017-08-21 909 runtime_put:
9a34b45397e5a3 Marek Szyprowski 2017-08-21 910 clk_pm_runtime_put(core);
9a34b45397e5a3 Marek Szyprowski 2017-08-21 911 return ret;
b2476490ef1113 Mike Turquette 2012-03-15 912 }
b2476490ef1113 Mike Turquette 2012-03-15 913
a6adc30ba7bef8 Dong Aisheng 2016-06-30 914 static int clk_core_prepare_lock(struct clk_core *core)
a6adc30ba7bef8 Dong Aisheng 2016-06-30 915 {
a6adc30ba7bef8 Dong Aisheng 2016-06-30 916 int ret;
a6adc30ba7bef8 Dong Aisheng 2016-06-30 917
a6adc30ba7bef8 Dong Aisheng 2016-06-30 918 clk_prepare_lock();
a6adc30ba7bef8 Dong Aisheng 2016-06-30 919 ret = clk_core_prepare(core);
a6adc30ba7bef8 Dong Aisheng 2016-06-30 920 clk_prepare_unlock();
a6adc30ba7bef8 Dong Aisheng 2016-06-30 921
a6adc30ba7bef8 Dong Aisheng 2016-06-30 922 return ret;
a6adc30ba7bef8 Dong Aisheng 2016-06-30 923 }
a6adc30ba7bef8 Dong Aisheng 2016-06-30 924
4dff95dc9477a3 Stephen Boyd 2015-04-30 925 /**
4dff95dc9477a3 Stephen Boyd 2015-04-30 926 * clk_prepare - prepare a clock source
4dff95dc9477a3 Stephen Boyd 2015-04-30 927 * @clk: the clk being prepared
4dff95dc9477a3 Stephen Boyd 2015-04-30 928 *
4dff95dc9477a3 Stephen Boyd 2015-04-30 929 * clk_prepare may sleep, which differentiates it from clk_enable. In a simple
4dff95dc9477a3 Stephen Boyd 2015-04-30 930 * case, clk_prepare can be used instead of clk_enable to ungate a clk if the
4dff95dc9477a3 Stephen Boyd 2015-04-30 931 * operation may sleep. One example is a clk which is accessed over I2c. In
4dff95dc9477a3 Stephen Boyd 2015-04-30 932 * the complex case a clk ungate operation may require a fast and a slow part.
4dff95dc9477a3 Stephen Boyd 2015-04-30 933 * It is this reason that clk_prepare and clk_enable are not mutually
4dff95dc9477a3 Stephen Boyd 2015-04-30 934 * exclusive. In fact clk_prepare must be called before clk_enable.
4dff95dc9477a3 Stephen Boyd 2015-04-30 935 * Returns 0 on success, -EERROR otherwise.
4dff95dc9477a3 Stephen Boyd 2015-04-30 936 */
4dff95dc9477a3 Stephen Boyd 2015-04-30 @937 int clk_prepare(struct clk *clk)
b2476490ef1113 Mike Turquette 2012-03-15 938 {
035a61c314eb3d Tomeu Vizoso 2015-01-23 939 if (!clk)
4dff95dc9477a3 Stephen Boyd 2015-04-30 940 return 0;
035a61c314eb3d Tomeu Vizoso 2015-01-23 941
a6adc30ba7bef8 Dong Aisheng 2016-06-30 942 return clk_core_prepare_lock(clk->core);
7ef3dcc8145263 James Hogan 2013-07-29 943 }
4dff95dc9477a3 Stephen Boyd 2015-04-30 944 EXPORT_SYMBOL_GPL(clk_prepare);
035a61c314eb3d Tomeu Vizoso 2015-01-23 945
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists