linux-kernel - Re: [PATCH] proc: use kmalloc instead of __get_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jan 2022 14:03:16 +0000
From:   Torin Carey <torin@...rey.uk>
To:     Hao Lee <haolee.swjtu@...il.com>
Cc:     akpm@...ux-foundation.org, christian.brauner@...ntu.com,
        keescook@...omium.org, adobriyan@...il.com,
        jamorris@...ux.microsoft.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: use kmalloc instead of __get_free_page() to alloc
 path buffer

On Sun, Jan 23, 2022 at 10:08:37AM +0000, Hao Lee wrote:
> It's not a standard approach that use __get_free_page() to alloc path
> buffer directly. We'd better use kmalloc and PATH_MAX.

If we're allocating PATH_MAX sized buffers for names, wouldn't it be
suitable to use the name slab names_cachep declared in
include/linux/fs.h using __getname() and __putname()?

Best,
Torin