linux-kernel - Re: [PATCH] net: tulip: remove redundant assignment to variable new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220125074512.73cc5cec@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 25 Jan 2022 07:45:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Colin Ian King <colin.i.king@...il.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-parisc@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tulip: remove redundant assignment to variable
 new_csr6

On Tue, 25 Jan 2022 17:14:01 +0300 Dan Carpenter wrote:
> You're looking at the wrong function.  This is pnic_do_nway() and you're
> looking at pnic_timer().

Ah, that explains it! Thanks, applied now.

> Of course, Colin's patch assumes the current behavior is correct...  I
> guess the current behavior can't be that terrible since it predates git
> and no one has complained.

Entirely possible this driver was never used in the git era.