linux-kernel - Re: [PATCH v3 2/4] Watchdog: sp5100_tco: Refactor MMIO base address initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220125191946.4213cbee@endymion>
Date:   Tue, 25 Jan 2022 19:19:46 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Terry Bowman <Terry.Bowman@....com>
Cc:     linux@...ck-us.net, linux-watchdog@...r.kernel.org,
        linux-i2c@...r.kernel.org, wsa@...nel.org,
        andy.shevchenko@...il.com, rafael.j.wysocki@...el.com,
        linux-kernel@...r.kernel.org, wim@...ux-watchdog.org,
        rrichter@....com, thomas.lendacky@....com,
        Nehal-bakulchandra.Shah@....com, Basavaraj.Natikar@....com,
        Shyam-sundar.S-k@....com, Mario.Limonciello@....com
Subject: Re: [PATCH v3 2/4] Watchdog: sp5100_tco: Refactor MMIO base address
 initialization

On Tue, 25 Jan 2022 12:02:45 -0600, Terry Bowman wrote:
> On 1/25/22 10:38 AM, Jean Delvare wrote:
> > On Tue, 25 Jan 2022 09:18:59 -0600, Terry Bowman wrote:  
> >> On 1/25/22 7:45 AM, Jean Delvare wrote:  
> >>> On Tue, 18 Jan 2022 14:22:32 -0600, Terry Bowman wrote:    
> >>>> (...)
> >>>> +	if (ret)
> >>>> +		dev_err(dev, "Failed to reserve-map MMIO (%X) and alternate MMIO (%X) regions. ret=%X",
> >>>> +			mmio_addr, alt_mmio_addr, ret);    
> > 
> > ... I think that should be a "or" rather than "and", and singular
> > "region", in this error message? I mean, the plan was never to
> > reserve-map both of them, if I understand correctly.
> >   
> 
> This dev_err() is executed when both mmio_addr and alt_mmio_addr addresses failed either 
> devm_request_mem_region() or failed devm_ioremap(). I think the following would be most accurate:
> 
> dev_err(dev, 
>         "Failed to reserve or map the MMIO (0x%X) and alternate MMIO (0x%X) regions, ret=%d",
>         mmio_addr, alt_mmio_addr, ret);  
> 
> Above is my preference but I don't have a strong opinion. Providing the address and error code 
> information in the message is most important. I will make the change as you requested. 

I agree, fine with me, no worry.

-- 
Jean Delvare
SUSE L3 Support