linux-kernel - Re: [PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83d085f0-8f2e-dc92-dab3-61c0b7677df8@intel.com>
Date:   Tue, 25 Jan 2022 10:52:19 -0800
From:   John Harrison <john.c.harrison@...el.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Matthew Brost <matthew.brost@...el.com>,
        <intel-gfx@...ts.freedesktop.org>,
        <dri-devel@...ts.freedesktop.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" ->
 "notification"

On 1/25/2022 01:13, Colin Ian King wrote:
> There is a spelling mistake in a drm_err error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Reviewed-by: John Harrison <John.C.Harrison@...el.com>

However, note that this message is going to be deleted anyway. Or at 
least dropped down to an informational. Partly, there was confusion over 
how the issue could arise. Partly the firmware bug leading to part of 
the problem has now been fixed and the w/a removed from the driver. 
Cleaning this error up accordingly is on my todo list...

Thanks,
John.


> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index 1331ff91c5b0..1ae3d1f259e3 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -3942,7 +3942,7 @@ static void guc_handle_context_reset(struct intel_guc *guc,
>   		guc_context_replay(ce);
>   	} else {
>   		drm_err(&guc_to_gt(guc)->i915->drm,
> -			"Invalid GuC engine reset notificaion for 0x%04X on %s: banned = %d, blocked = %d",
> +			"Invalid GuC engine reset notification for 0x%04X on %s: banned = %d, blocked = %d",
>   			ce->guc_id.id, ce->engine->name, intel_context_is_banned(ce),
>   			context_blocked(ce));
>   	}